[Lv.8+] 예외 처리, 코드 개선, README 작성 - 황도일#57
Open
DoyleHWorks wants to merge 14 commits intoSpartaCoding-iOS5:Maccha_0.2.0from
Open
[Lv.8+] 예외 처리, 코드 개선, README 작성 - 황도일#57DoyleHWorks wants to merge 14 commits intoSpartaCoding-iOS5:Maccha_0.2.0from
DoyleHWorks wants to merge 14 commits intoSpartaCoding-iOS5:Maccha_0.2.0from
Conversation
Separate Model(CalculatorLogic, CalculatorLogicDelegate) from ViewController
Delete getExpression(), Add comment to CalculatorLogic
UX Improvement: Overwrite last operator input
Input Validation (exception handling)
Input Validation: remove leading zeros after operator inputs
Show more text with less limitation
Supports more screen sizes: iPhone SE 3, iPad, ... Layout calculation base changed: from expressionLabel to superButtonStack
Targeted Device Family: iPhones Orientation: Portrait mode only UI Status Bar Style: Dark Content
Improve structure of existing input validations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development: 0.0.8 -> 0.2.0
ViewController로부터 Model(CalculatorLogic,CalculatorLogicDelegate)을 분리Portrait Mode Only로 제한, 표현식 라벨의 동적 폰트 스케일링 구현중복된 연산자extension과MARK주석으로 분리연산자로 끝나는 식,0으로 시작하는 숫자 (Case B)iPhone Pro 16에 더불어iPhone SE 3과iPad Pro 11-inch환경도 테스트leading/trailing을left/right로 변경하여 제한Target Family: iPhones/Portrait Mode Only/UI Status Bar Style: Dark Content0으로 나누기